Nice to have: BinarySearch and Sort method on generated collections

[DeepDiver]

hi,

in case sequence<> is generated with the meta tag ["cs:collection"]
it would be nice to have the BinarySearch and Sort methods available.

the generated code will look like:

	public int BinarySearch(C value)
	{
	    return InnerList.BinarySearch(value);
	}

	public void Sort()
	{
	    return InnerList.Sort();
	}

this is actually pretty straight foreward.

thx & cu tom


PS: adding the contructor with parameter ICollection c would help as well.

[michi]

Originally Posted by DeepDiver

in case sequence<> is generated with the meta tag ["cs:collection"]
it would be nice to have the BinarySearch and Sort methods available.

I don't see any problem with this, so I'll add this for the next release.

adding the contructor with parameter ICollection c would help as well.

I'm reluctant to add this because it would open up a hole in the type system: if I pass a collection with elements of the wrong type to this constructor, I won't be told at compile time. Instead, the constructor would have to throw an exception at run time if the elements cannot be cast to the expected element type.

Overall, I think it's preferable to write a foreach loop explicitly to populate the collection. At least, that way, the cast is explicit and I can see what is going on in the code.

Cheers,

Michi.

[DeepDiver]

hi michi,

thank you for adding this feature to the next release!

i totally agree with you about the type safty issue.
we will no longer have these troubles with .Net 2.0, when we can
make use of generics.

any plans on .Net 2.0 and generics?

thx & take care,

tom

[michi]

Originally Posted by DeepDiver

any plans on .Net 2.0 and generics?

Not just yet, but we will probably provide a new mapping at some point that makes use of the new features.

Cheers,

Michi.