slice2cpp generate bad string literals

[jbrouault]

I'm using Ice 3.4.1 on linux build with gcc 4.4.3 and linked against the ZeroC patched version of mcpp.

slice2cpp generates bad code for the following slice :

module Foo
{
const string bar = "foo\"quoted\"bar";
};

The generated code is below, the double quotes inside the string aren't escaped anymore:

const ::std::string bar = "foo"quoted"bar";

If in the slice I use bar = "foo\\\"quoted\\\"bar" then slice2cpp generates valid c++ code.

I guess that the function writeConstantValue() in slice2cpp/Gen.cpp should do something similar to Slice::JavaVisitor::writeConstantValue() in the java generator.

Regards,
Jean-Baptiste

[mes]

Hi,

Thanks for reporting this.

Regards,
Mark

[chow]

slice file snippet:

["clrroperty", "clr:class", "cpp:class"] struct RaceXPAdjState {
RACECLSSKEY key;
float xpAdj = 1.0;
};

produces:


Ixxon::RaceXPAdjState::RaceXPAdjState() :
xpAdj(1F)
{
}

which when compiling give the following errors:

1>Ixxon.cpp(3382): error C2059: syntax error : 'bad suffix on number'
1>Ixxon.cpp(3382): error C2146: syntax error : missing ')' before identifier 'F'
1>Ixxon.cpp(3382): error C2612: trailing 'identifier' illegal in base/member initializer list
1>Ixxon.cpp(3382): error C2059: syntax error : ')'
1>Ixxon.cpp(3383): error C2065: 'F' : undeclared identifier

Manually changing (1F) to (1.0F) fixes the problem.

[chow]

Forgot to mention, this is with Ice 3.4.2. I never had a problem with 3.4.1 so I am not sure what it used to generate.

[bernard]

Hi Brian,

Unfortunately it's a bug that was introduced in 3.4.2. See default vaules in Slice for a work-around.

Best regards,
Bernard